Skip to content

Conversation

@christianlupus
Copy link
Collaborator

Fixes #284

This should fix the import issues related to different encodings of recipes.

@github-actions
Copy link

github-actions bot commented Jun 24, 2022

Unit Test Results

     36 files       36 suites   8m 24s ⏱️
   224 tests    224 ✔️ 0 💤 0
2 688 runs  2 688 ✔️ 0 💤 0

Results for commit cc04c09.

♻️ This comment has been updated with latest results.

Signed-off-by: Christian Wolf <[email protected]>
@christianlupus christianlupus force-pushed the fix/284-import-encoding-utf8 branch from cee2209 to cc04c09 Compare June 24, 2022 14:52
@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #1057 (c862b15) into master (f0fc4ce) will increase coverage by 3.48%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1057      +/-   ##
==========================================
+ Coverage   41.09%   44.58%   +3.48%     
==========================================
  Files          46       50       +4     
  Lines        1925     1965      +40     
==========================================
+ Hits          791      876      +85     
+ Misses       1134     1089      -45     
Flag Coverage Δ
integration 2.29% <2.32%> (?)
migration 4.32% <0.00%> (-0.09%) ⬇️
unittests 37.96% <97.67%> (+1.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/Exception/CouldNotGuessEncodingException.php 100.00% <100.00%> (ø)
lib/Helper/DownloadEncodingHelper.php 100.00% <100.00%> (ø)
lib/Helper/DownloadHelper.php 100.00% <100.00%> (+100.00%) ⬆️
lib/Helper/EncodingGuessingHelper.php 100.00% <100.00%> (ø)
lib/Helper/HTMLFilter/HtmlEncodingFilter.php 100.00% <100.00%> (ø)
lib/Service/HtmlDownloadService.php 100.00% <100.00%> (ø)
lib/Exception/NoDownloadWasCarriedOutException.php 100.00% <0.00%> (+100.00%) ⬆️

Signed-off-by: Christian Wolf <[email protected]>
@christianlupus christianlupus merged commit c5c9ea7 into master Jun 24, 2022
@christianlupus christianlupus deleted the fix/284-import-encoding-utf8 branch June 24, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Encoding errors with recipes from hellofresh.ch

2 participants